ENH: Changing ellipses plot axis label #855
Merged
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@ArthurJWH the PR is simple and straightforward, thx for that!
- Could you provide us a screenshot of your results please? This makes review easier since I won't have to run several simulations to obtain the new plots.
- Could you kindly update the CHANGELOG pls?
After these 2 points, I believe we will merge it directly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #855 +/- ##
===========================================
+ Coverage 80.02% 80.28% +0.26%
===========================================
Files 98 104 +6
Lines 12004 12764 +760
===========================================
+ Hits 9606 10248 +642
- Misses 2398 2516 +118 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Gui-FernandesBR
force-pushed
the
enh/changing-ellipses-axis-label
branch
from
3bbe340 to
6713f0b
Compare
Gui-FernandesBR
approved these changes
Oct 8, 2025
…/RocketPy-Team/RocketPy into enh/changing-ellipses-axis-label
Gui-FernandesBR
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
The axis use North and East as labels
New behavior
Label the extremes of the axis as North-South and West-East
Breaking change